Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update workflow to check code format #10

Merged

Conversation

osmanhadzic
Copy link
Collaborator

Add a new step in the GitHub Actions workflow to perform format checking using black. Additionally, it includes minor formatting improvements in the test files.

The main purpose of this change is to ensure that the code adheres to a consistent style, reducing the likelihood of formatting-related issues during code reviews and improving overall code readability.

  • Added a new step in the .github/workflows/astarte-ctl-test.yaml file to check the format of the test files using black.
  • Updated the tests/pyproject.toml file to include black as a dependency.
  • Made minor formatting changes in tests/conftest.py and tests/test_app_engine.py to comply with the black formatting style.

Testing

  • Format Check: The new workflow step will automatically check the format of the test files using black and report any issues.

@osmanhadzic osmanhadzic self-assigned this Nov 4, 2024
@osmanhadzic osmanhadzic force-pushed the update-workflow-check-format branch from ba031d8 to 7491986 Compare November 5, 2024 14:19
@osmanhadzic osmanhadzic force-pushed the update-workflow-check-format branch from 7491986 to 8c6cf42 Compare November 6, 2024 11:23
- Add code formatting check to the astarte-ctl-test workflow.
- Apply Black code formatting to the tests directory using the command
  `python -m black tests/`.

Signed-off-by: Osman Hadzic <[email protected]>
@osmanhadzic osmanhadzic force-pushed the update-workflow-check-format branch from 8c6cf42 to 553fef2 Compare November 6, 2024 15:11
@Annopaolo Annopaolo merged commit 7fc374b into astarte-platform:main Nov 6, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants